Skip to content

Fix for Android SDK 28 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for Android SDK 28 #368

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71f969e
Use the sdk- and buildtools-versions from root project
jan-happy Feb 19, 2019
8512582
Use the sdk- and buildtools-versions from root project
jan-happy Feb 19, 2019
747c09b
Merge branch 'master' of https://github.com/egodigital/react-native-p…
jan-happy Feb 19, 2019
59e0244
update android support library to androidx
jan-happy Sep 5, 2019
5cb4418
Rollback
jan-happy Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
apply plugin: 'com.android.library'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion 27
buildToolsVersion "23.0.1"
compileSdkVersion safeExtGet('compileSdkVersion', 27)
buildToolsVersion safeExtGet('buildToolsVersion', '23.0.1')

defaultConfig {
minSdkVersion 16
targetSdkVersion 27
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 27)
versionCode 1
versionName "1.0"

Expand Down