Add ability to multiselect groups#1559
Merged
alexbakker merged 1 commit intobeemdevelopment:masterfrom Feb 24, 2025
Merged
Conversation
alexbakker
requested changes
Dec 20, 2024
Member
There was a problem hiding this comment.
Something appears to not be quite right when including "No group" in the filter" + another group. If I save that filter and reopen the app, only "No group" is checked. If I then tap to include the other group in the filter, only the entries in that other group are shown, the "No group" chip remains checked but the entries without a group vanish.
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
4 times, most recently
from
9fcc064 to
c9a4e77
Compare
alexbakker
requested changes
Jan 1, 2025
Member
alexbakker
left a comment
alexbakker
left a comment
There was a problem hiding this comment.
Noticed another issue:
- Have a bunch of entries (one entry in a "Test" group)
- Filter on the "Test" group
- Tap "No group" to add it to the filter
- Tap "Test" to remove it from the filter
- Tap "No group" to remove it from the filter
- Tap "Test" to add it to the filter
- Result: All entries are shown instead of just the entry in the "Test" group
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
c9a4e77 to
fd0dcaf
Compare
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
1584f4f to
fd0dcaf
Compare
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
fd0dcaf to
957cc01
Compare
Member
Author
|
Latest push also fixed a bug where a saved single selection groupfilter was not being displayed properly upon launching the app. |
alexbakker
requested changes
Jan 24, 2025
Member
alexbakker
left a comment
alexbakker
left a comment
There was a problem hiding this comment.
It looks like saved filters are not applied on startup: https://alexbakker.me/u/tn6w0snc89.webm
app/src/main/java/com/beemdevelopment/aegis/ui/MainActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/MainActivity.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
957cc01 to
fd0dcaf
Compare
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
fd0dcaf to
78ee38b
Compare
alexbakker
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle to allow multi selection of groups in the main activity as requested in #1555.
Fixes #1555