-
Notifications
You must be signed in to change notification settings - Fork 6
Add message requests to dummybridge #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe changes upgrade Go tooling and dependencies, and extend the DummyBridge connector with message request handling by implementing new network APIs, adding command handlers for creating message request portals, and generating appropriate portal configurations. Changes
Sequence DiagramsequenceDiagram
actor User
participant Commands
participant Portal Creation
participant Bridge
participant Database
participant Matrix Room
User->>Commands: Trigger NewRequestDMCommand
Commands->>Portal Creation: Call createMessageRequestPortal(isGroup=false)
Portal Creation->>Database: Generate portalID & PortalKey
Portal Creation->>Database: Fetch/create portal
Portal Creation->>Database: Create/update ghost members
Portal Creation->>Bridge: Build ChatInfo with config
Portal Creation->>Matrix Room: CreateMatrixRoom
Matrix Room-->>Bridge: Room created
alt sendInitialMessage = true
Portal Creation->>Bridge: Queue initial dummy message
Bridge->>Matrix Room: Insert message from ghost
end
Bridge-->>User: Return portal MXID
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✏️ Tip: You can disable this entire section by setting Comment |
tulir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything marking chats as message requests
|
whoops missed a file, updated |
tulir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it might work
No description provided.