Skip to content

Conversation

@adamvy
Copy link
Member

@adamvy adamvy commented Jan 14, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added commands to create DM and group message request portals.
    • Enhanced portal capabilities with message handling improvements, proper timestamps, and metadata.
  • Chores

    • Updated Go toolchain and dependencies to latest versions.
    • Updated container builder image to Alpine 3.23.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The changes upgrade Go tooling and dependencies, and extend the DummyBridge connector with message request handling by implementing new network APIs, adding command handlers for creating message request portals, and generating appropriate portal configurations.

Changes

Cohort / File(s) Summary
Build & Dependency Management
cmd/dummybridge/Dockerfile, go.mod
Updates builder stage image to alpine3.23; bumps Go version to 1.24.0 and toolchain to 1.25.0; refreshes multiple module versions (mautrix, crypto, net, sys, sqlite3, and others)
Message Request Portal Creation
pkg/connector/message_requests.go
Adds NewRequestDMCommand and NewRequestGroupCommand handlers; implements createMessageRequestPortal helper function for generating DM/group message request portals with optional initial dummy messages and configurable remote member counts
Client API Implementation
pkg/connector/client.go
Implements BackfillingNetworkAPI, DeleteChatHandlingNetworkAPI, and MessageRequestAcceptingNetworkAPI interfaces; adds portal capabilities descriptor; enhances HandleMatrixMessage with message ID and timestamp derivation; adds HandleMatrixDeleteChat and HandleMatrixAcceptMessageRequest handlers
Command & Portal Configuration
pkg/connector/commands.go, pkg/connector/generators.go
Registers new message request commands in AllCommands; implements portal name/topic generation and chat configuration setup based on portal ID and member count

Sequence Diagram

sequenceDiagram
    actor User
    participant Commands
    participant Portal Creation
    participant Bridge
    participant Database
    participant Matrix Room

    User->>Commands: Trigger NewRequestDMCommand
    Commands->>Portal Creation: Call createMessageRequestPortal(isGroup=false)
    Portal Creation->>Database: Generate portalID & PortalKey
    Portal Creation->>Database: Fetch/create portal
    Portal Creation->>Database: Create/update ghost members
    Portal Creation->>Bridge: Build ChatInfo with config
    Portal Creation->>Matrix Room: CreateMatrixRoom
    Matrix Room-->>Bridge: Room created
    alt sendInitialMessage = true
        Portal Creation->>Bridge: Queue initial dummy message
        Bridge->>Matrix Room: Insert message from ghost
    end
    Bridge-->>User: Return portal MXID
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch adam/message-requests


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9822e57 and 2161dab.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • cmd/dummybridge/Dockerfile
  • go.mod
  • pkg/connector/client.go
  • pkg/connector/commands.go
  • pkg/connector/generators.go
  • pkg/connector/message_requests.go

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@adamvy adamvy requested a review from tulir January 14, 2026 22:38
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything marking chats as message requests

@adamvy
Copy link
Member Author

adamvy commented Jan 14, 2026

whoops missed a file, updated

Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it might work

@adamvy adamvy marked this pull request as ready for review January 14, 2026 22:54
@adamvy adamvy merged commit 0320002 into main Jan 14, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants