Update why windows tests skipped #5858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove `force_implicit_query_detection` attribute from `PathQuery` class.
The case_sensitive parameter was only used in tests, which now use monkeypatch to control the behavior of util.case_sensitive() instead. This simplifies the PathQuery initialization logic while maintaining test coverage.
And rewrite test_query.py
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
3 tasks
snejus
reviewed
Jul 6, 2025
| @@ -36,6 +41,8 @@ def test_failing_to_set_permissions(self): | |||
| def do_thing(self, expect_success): | |||
| if platform.system() == "Windows": | |||
| self.skipTest("permissions not available on Windows") | |||
| if is_wsl_and_ntfs(os.getcwd()): # WSL on NTFS does not support chmod | |||
There was a problem hiding this comment.
What does platform return for WSL? Isn't it Windows? If so, it seems that the check on line 37 already skips the test?
snejus
force-pushed
the
speed-up-test-query
branch
3 times, most recently
from
875025b to
443ed57
Compare
|
All of the related work has now been merged to master, so you can now rebase your commits on master, apologies for the back and forth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify why tests on Windows are skipped.
Replaces #5812
Some tests pass in CI, but fail locally.
To Do
Not all skips looked at as yet.
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)