Skip to content

Unimported plugin - new option to add globbing #5867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mikaciu
Copy link

@Mikaciu Mikaciu commented Jul 9, 2025

Description

Add a new option, ignore_as_globs to consider the ignore_subdirectories as globs, the same way the ignore section works.

Using this flag, the unimported plugin is walking through the library using the util.sorted_walk method, the same way the importer does.

To Do

  • I didn't find a way to access the beets config from a plugin (maybe due to the fact that plugin config is namespaced). An improvement would have been to use the ignore config value instead of duplicating it.
  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.) <-- will be done after review ;)
  • Tests. (Very much encouraged but not strictly required.)

Copy link

github-actions bot commented Jul 9, 2025

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

…rectories as globs

Uses the same method to go through the files than the importer, `util.sorted_walk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant