Skip to content

logging: make levels/formats configurable #5897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

9999years
Copy link
Contributor

Description

This keeps the root logger from swallowing logs, for example logs emitted by plugins and dependencies (such as the MusicBrainz API client).

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@9999years 9999years force-pushed the configure-root-logger branch from 2cb2f09 to 4a82a03 Compare July 28, 2025 03:28
@9999years 9999years changed the title logging: set root logger level/handler logging: make levels/formats configurable Jul 28, 2025
@9999years 9999years mentioned this pull request Jul 28, 2025
3 tasks
@9999years 9999years force-pushed the configure-root-logger branch 11 times, most recently from b10f910 to 51a9457 Compare July 28, 2025 06:41
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.72%. Comparing base (5beb3d1) to head (071b4e1).

Files with missing lines Patch % Lines
beets/ui/__init__.py 70.00% 8 Missing and 1 partial ⚠️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This makes it possible to filter logs on a per-module basis.
This was leading to crashes due to the beets log formatting infra not
being in place.
This allows users to prevent the root logger from swallowing logs, for
example logs emitted by plugins and dependencies (such as the
MusicBrainz API client).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant