-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Alias functionality for Composers in Musicbrainz autotagger. #5900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the MusicBrainz autotagger to apply preferred alias functionality to composer names, similar to how it already works for artist names. This ensures composer names are localized according to user preferences.
- Adds alias checking for composers using the existing
_preferred_alias
function - Applies alias resolution to both composer names and sort names
- Maintains the same localization logic already used for artists
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
docs/changelog.rst | Documents the new composer alias functionality |
beetsplug/musicbrainz.py | Implements alias checking for composers in the track_info function |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Sorry if this created some spam in your inbox, I'm new to using github, but I think I addressed the mistakes in my last PR. Let me know if you want me to combine these various commits into something cleaner, or re-do anything, or start from scratch. Thank you! |
Description
This PR updates the MusicBrainz autotagger to check composer names against preferred aliases, applying the same logic used for localized artist name selection.
Fixes #5885.
To Do
This is a simple change that appears to work correctly in practice. I’m still exploring the test suite and would appreciate feedback on whether additional tests or documentation are needed. Thanks!