Skip to content

Add Alias functionality for Composers in Musicbrainz autotagger. #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NoDancing
Copy link

Description

This PR updates the MusicBrainz autotagger to check composer names against preferred aliases, applying the same logic used for localized artist name selection.

Fixes #5885.

To Do

  • Documentation. (Unclear if any is needed, let me know!)
  • Changelog.
  • Tests. (initial implementation works; still experimenting with test coverage).

This is a simple change that appears to work correctly in practice. I’m still exploring the test suite and would appreciate feedback on whether additional tests or documentation are needed. Thanks!

@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 05:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the MusicBrainz autotagger to apply preferred alias functionality to composer names, similar to how it already works for artist names. This ensures composer names are localized according to user preferences.

  • Adds alias checking for composers using the existing _preferred_alias function
  • Applies alias resolution to both composer names and sort names
  • Maintains the same localization logic already used for artists

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/changelog.rst Documents the new composer alias functionality
beetsplug/musicbrainz.py Implements alias checking for composers in the track_info function

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.74%. Comparing base (d8d227e) to head (8c07148).

Files with missing lines Patch % Lines
beetsplug/musicbrainz.py 44.44% 3 Missing and 2 partials ⚠️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NoDancing NoDancing marked this pull request as draft August 9, 2025 02:22
@NoDancing
Copy link
Author

Sorry if this created some spam in your inbox, I'm new to using github, but I think I addressed the mistakes in my last PR. Let me know if you want me to combine these various commits into something cleaner, or re-do anything, or start from scratch. Thank you!

@NoDancing NoDancing marked this pull request as ready for review August 9, 2025 03:43
@NoDancing NoDancing marked this pull request as draft August 9, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composer not translated from non western language with import/languages set to en
2 participants