Adds a zero_disc_number_if_single_disc to the zero plugin
#5909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `zero_disc_number_if_single_disc` boolean to the zero plugin for writing to files. Adds the logic that, if disctotal is set and there is only one disc in disctotal, that the disc is not set. This keeps tags cleaner, only using disc on multi-disc albums. The disctotal is not touched, particularly as this is not usually displayed in most clients. The field is kept only for writing the tags, but the disc number is maintained in the database.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
Would love to hear some feedback on this or its implementation. |
snejus
requested changes
Aug 9, 2025
| @@ -123,8 +124,13 @@ def set_fields(self, item, tags): | |||
| """ | |||
| fields_set = False | |||
|
|
|||
| if 'disc' in tags and self.config["zero_disc_number_if_single_disc"].get(bool): | |||
| if getattr(item, 'disctotal', None) == 1: | |||
There was a problem hiding this comment.
I think you can access this attribute directly
Suggested change
| if getattr(item, 'disctotal', None) == 1: | |
| if item.disctotal == 1: |
| @@ -123,8 +124,13 @@ def set_fields(self, item, tags): | |||
| """ | |||
| fields_set = False | |||
|
|
|||
| if 'disc' in tags and self.config["zero_disc_number_if_single_disc"].get(bool): | |||
| if getattr(item, 'disctotal', None) == 1: | |||
| self._log.debug("{0}: {1} -> None", 'disc', item['disc']) | |||
There was a problem hiding this comment.
Suggested change
| self._log.debug("{0}: {1} -> None", 'disc', item['disc']) | |
| self._log.debug("disc: {.disc} -> None", item) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
zero_disc_number_if_single_discboolean to the zero plugin for writing to files. Adds the logic that, if disctotal is set and there is only one disc in disctotal, that the disc is not set.This keeps tags cleaner, only using disc on multi-disc albums. The disctotal is not touched, particularly as this is not usually displayed in most clients.
The field is removed only for writing the tags, but the disc number is maintained in the database to avoid breaking anything that may depend on a disc number or avoid possible loops or failed logic.
A column of disc 1 makes me feel there should be a disc 2, when most albums are a single disc only.
Description
This addresses concerns such as https://beets-users.narkive.com/fxh0cgmC/beets-remove-disc-field-for-single-disc-albums and accomplishes things like #5670 but in tags instead of just in the path.
To Do