-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rafactored beets/random.py and moved into beetsplug/random.py #5924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the beets/random.py
module into beetsplug/random.py
to consolidate random functionality with its only consumer, the random plugin, thereby keeping core modules cleaner.
- Moved all functions from
beets/random.py
intobeetsplug/random.py
- Added comprehensive type hints for better code clarity and tooling support
- Enhanced test coverage with additional test cases for edge cases and different functionality modes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
beets/random.py | Complete removal of the standalone random module |
beetsplug/random.py | Integration of moved functions with added type hints and improved implementation |
test/plugins/test_random.py | Updated import path and added comprehensive test cases for better coverage |
13aa1e0
to
daf1136
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
The
beets/random.py
module was only used by the random plugin, so I moved its functions intobeetsplug/random.py
to keep core modules cleaner.Changes: