Conversation
Serene-Arc
left a comment
There was a problem hiding this comment.
This is a good clarification for the behaviour you had a problem with, but I wonder if this is something that only makes sense for programmers. Then again, this might be something that only programmers or people somewhat familiar with programming conventions understand. Might not be a problem in that case.
Perhaps make it clear that for different data types, some are always interpreted as False. 0 is that for an integer, False for a boolean, '' for a string, etc.
I agree that it might be confusing to some people not having the prerequisite programming knowledge, but I still think those people would be better off with more documentation that can at least point them in the right direction/help them ask the right questions when asking for help.
This is a great point, I had not considered this at all! |
snejus
left a comment
There was a problem hiding this comment.
Would you mind adding some examples for the %if function behaviour, following what we have under %first{text,count,skip,sep,join} below?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6399 +/- ##
==========================================
+ Coverage 69.18% 69.33% +0.15%
==========================================
Files 140 141 +1
Lines 18686 18793 +107
Branches 3053 3061 +8
==========================================
+ Hits 12927 13031 +104
- Misses 5114 5117 +3
Partials 645 645 🚀 New features to boost your workflow:
|
Description
Fixes #4991.
I don't know if there's a single, good workaround for this, so I opted to not add an example solution.
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)