Enable language selector. #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
approved these changes
Nov 4, 2025
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Looks great; the only suggestion I've got can't be fixed in this repo: we should add a style clearing the max-height on the menu item. The scroll bar is a little cumbersome.
However, that's a docs-tools fix; approving this PR as it looks good to go; once we've got a fix in docs-tools, we can rebuild and/or merge this one.
Contributor
Author
|
Fix is in: beeware/beeware-docs-tools#92 |
Contributor
Author
|
@freakboy3742 I rebuilt English. The docs-tools fix worked. |
Member
|
Still getting some weird hover behavior... |
Member
|
Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist: