Skip to content

Conversation

@johnzhou721
Copy link
Contributor

@johnzhou721 johnzhou721 commented Jul 1, 2025

Fixes #676. Note that as soon as you merge this, be on the lookout for a message on #687 indicating you to merge that PR (Not Yet). That way we test this change. More details there.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@johnzhou721 johnzhou721 mentioned this pull request Jul 1, 2025
4 tasks
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all makes sense; I've made a couple of minor tweaks, and added an org-wide WEBLATE_API_TOKEN secret. Lets see if this works...

run: |
wlc pull
wlc unlock
rm ~/.config/weblate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do cleanup like this; if anything, it's better to leave a config like this around so that we can diagnose problems later.

Suggested change
rm ~/.config/weblate

We should probably also split this into two parts - the pull (which is only needed if there have been updates), and the unlock (which is always needed).

env:
WEBLATE_API_TOKEN: ${{ secrets.WEBLATE_API_TOKEN }}
run: |
pip install wlc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't version locked; we should just add wlc to the site requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Weblate Commit Before We Run Update Translations Commits

2 participants