-
-
Notifications
You must be signed in to change notification settings - Fork 820
Pull Weblate Changes Before Updating Translations #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
freakboy3742
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all makes sense; I've made a couple of minor tweaks, and added an org-wide WEBLATE_API_TOKEN secret. Lets see if this works...
.github/workflows/publish.yml
Outdated
| run: | | ||
| wlc pull | ||
| wlc unlock | ||
| rm ~/.config/weblate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do cleanup like this; if anything, it's better to leave a config like this around so that we can diagnose problems later.
| rm ~/.config/weblate |
We should probably also split this into two parts - the pull (which is only needed if there have been updates), and the unlock (which is always needed).
.github/workflows/publish.yml
Outdated
| env: | ||
| WEBLATE_API_TOKEN: ${{ secrets.WEBLATE_API_TOKEN }} | ||
| run: | | ||
| pip install wlc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't version locked; we should just add wlc to the site requirements.
Fixes #676. Note that as soon as you merge this, be on the lookout for a message on #687 indicating you to merge that PR (Not Yet). That way we test this change. More details there.
PR Checklist: