Skip to content

Document visionOS Support #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

Document visionOS Support #53

merged 4 commits into from
Apr 15, 2025

Conversation

@johnzhou721
Copy link
Contributor

@johnzhou721 johnzhou721 commented Apr 14, 2025

visionOS support is documented, refs #52, #49, and #50.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Apr 14, 2025

Wait CI failing?

@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Apr 14, 2025

Yeah, XZ is fetched this time. I was like what, didn't I just change the README? What happened? I was panicking at that time, practically.

@freakboy3742
Copy link
Member

freakboy3742 commented Apr 15, 2025

Wait CI failing?

Yeah - GitHub Actions runners have a surprisingly difficult time maintaining a connection to the internet. Downloads of large files fail... a lot more often than they should - even when the file is being downloaded from Github.

freakboy3742
freakboy3742 approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor grammar fixes, but otherwise this looks great - thanks!

johnzhou721 and others added 2 commits April 14, 2025 19:04
@johnzhou721
Some fixes
4202d55
@johnzhou721 @freakboy3742
Update README.rst
bc2256a 
Co-authored-by: Russell Keith-Magee <[email protected]>
@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Apr 15, 2025

Done!

@johnzhou721

This comment was marked as off-topic.

Sign in to view
@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Apr 15, 2025

CI failing --- AGAIN???

@freakboy3742
Copy link
Member

freakboy3742 commented Apr 15, 2025

CI failing --- AGAIN???

If you just got a notification about a CI failure, it's likely because a previous run was cancelled, not an actual failure. Github's UX around "failures you actually need to action" and "cancellations that are literally what we asked you to do" leaves a lot to be desired.

@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Apr 15, 2025

Oops. Yeah you're right

@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Apr 15, 2025

CI passed. Let us merge!!!

@freakboy3742 freakboy3742 merged commit 88a564f into beeware:main Apr 15, 2025
4 checks passed
johnzhou721
johnzhou721 commented May 18, 2025
View reviewed changes
Copy link
Contributor Author

@johnzhou721 johnzhou721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was from a finished PR, this got merged, but I always forget to click Submit Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnzhou721 @freakboy3742