認証周り by proto08 · Pull Request #8 · befoafsuger/rizap2025

proto08 · 2025-12-13T05:27:33Z

実装中

Summary by CodeRabbit

New Features
- Login/signup flow with session and access-token handling; backend user creation; new login screen UI
- Added multiple exercise modes (running, walking, squat, lunge, pushup, plank, jumping_jack, situp, burpee, standing)
Removed
- Previous tab bar navigation and Explore screen
Chores
- App config updated with iOS/Android identifiers; dependency and script updates for native features and libraries

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-13T05:27:51Z

Warning

Rate limit exceeded

@yuk228 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 42 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 785b353 and 113a883.

📒 Files selected for processing (1)

frontend/app/_layout.tsx (2 hunks)

Walkthrough

Removes the tab-based Explore layout, adds an auth-first IndexScreen and LoginScreen, integrates Supabase client and session/access-token hooks, adds signup/create-user flows (Formik + Yup + SWR), moves shared hooks under services, introduces new entities/types, updates dependencies and Expo identifiers.

Changes

Cohort / File(s)	Summary
App Configuration `frontend/app.json`	Added `expo.ios.bundleIdentifier` and `expo.android.package` set to "com.anonymous.rizap2025".
Navigation / Layout `frontend/app/_layout.tsx`, `frontend/app/index.tsx`, `frontend/app/(tabs)/_layout.tsx`, `frontend/app/(tabs)/explore.tsx`	Removed tab layout and explore screen files; changed color-scheme import path; removed `unstable_settings` anchor; Root layout screen name changed to `"index"`; StatusBar set to `style="light"` and hidden; new IndexScreen conditionally renders `LoginScreen` or `HomeScreen`.
New UI Component `frontend/components/login-screen.tsx`	Added `LoginScreen` component with email/password inputs, basic validation, and `onLogin` callback prop.
Import Path Moves (hooks → services) `frontend/components/parallax-scroll-view.tsx`, `frontend/components/themed-text.tsx`, `frontend/components/themed-view.tsx`, `frontend/components/ui/collapsible.tsx`, `frontend/services/shared/use-theme-color.ts`	Updated imports from `@/hooks/...` to `@/services/shared/...`; no behavioral changes.
Auth Services & Hooks `frontend/services/auth/session.ts`, `frontend/services/auth/create-user.ts`, `frontend/services/auth/signin.ts`, `frontend/services/auth/signup.ts`	Added `useSession` and `useAccessToken` hooks (Supabase-backed), `useCreateUser` (SWR mutation POST /users), and signup/signin hooks that wire Formik+Yup, call Supabase signUp, obtain access token, and call backend user creation.
Database Client (Supabase) `frontend/services/database/supabase.ts`	Added Supabase client initialization for React Native (AsyncStorage polyfill, auth config, auto-refresh, AppState foreground handling) and exported `supabase`.
Entities & Types `frontend/entities/game/mode.ts`, `frontend/entities/users/users.ts`, `frontend/entities/shared/formik.ts`	Added `Mode` enum (exercise modes), `createUserResponse` interface, and `FormikReturnType<T>` alias.
Removed API Helpers `frontend/utils/api.ts`	Deleted API helper module (types and helper functions for users/enemies/battle logs removed).
Hono / Client stub `frontend/hono/client.mts`	Added file with import of backend AppType and hono/client; export commented out (no active exports).
Dependencies & Scripts `frontend/package.json`	Updated `android`/`ios` scripts to `expo run:android`/`expo run:ios`; added dependencies including `@react-native-async-storage/async-storage`, `@supabase/supabase-js`, `formik`, `swr`, `yup`, various Expo packages, and others.

Sequence Diagram

sequenceDiagram
    actor User
    participant App as IndexScreen
    participant LoginUI as LoginScreen
    participant SignUpHook as useSignUp / useCreateUser
    participant Supabase as Supabase Auth
    participant Backend as Backend API
    participant SessionHook as useAccessToken
    participant Home as HomeScreen

    User->>App: Open app
    alt no session / not logged in
        App->>LoginUI: Render LoginScreen
        User->>LoginUI: Enter credentials & tap Login
        LoginUI->>SignUpHook: onLogin (submit)
        SignUpHook->>Supabase: signUp(email,password)
        Supabase-->>SignUpHook: Auth session
        SignUpHook->>SessionHook: retrieve access token
        SessionHook-->>SignUpHook: accessToken
        SignUpHook->>Backend: POST /users { id, displayName, accessToken }
        Backend-->>SignUpHook: created user response
        SignUpHook-->>App: signal successful login
        App->>Home: Render HomeScreen
    else already authenticated
        App->>Home: Render HomeScreen
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Areas to focus on:
- Supabase client config and AppState-based refresh logic (frontend/services/database/supabase.ts)
- Auth flows, token retrieval and error handling in signup/signin hooks (frontend/services/auth/*.ts)
- Route/name changes and removed tab files that may break existing navigation links (frontend/app/*)
- Deleted API helper surface (frontend/utils/api.ts) and any callers that must be updated
- Dependency additions in frontend/package.json (ensure native modules / Expo compatibility)

Possibly related PRs

feat:add-frontend-home #5 — Modifies frontend/utils/api.ts; likely directly related because this PR deletes that file while the referenced PR adds/changes an implementation.

Poem

🐰 I hopped in lines of code today,
Tabs tucked away, the login greets the way.
Supabase sings, new users take flight,
Formik holds the keys at night.
Tiny hops, big features — delight! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title check	❓ Inconclusive	The title '認証周り' (roughly 'auth-related' or 'around auth') is vague and does not clearly convey the scope of changes; while authentication-related changes are present, the PR includes substantial additional modifications to UI layout, routing, components, and dependencies that extend well beyond authentication.	Revise the title to be more specific and comprehensive, such as 'Refactor authentication flow with UI restructuring and dependency updates' or break this into multiple focused PRs by feature area.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 12

🧹 Nitpick comments (5)

frontend/components/login-screen.tsx (2)
10-12: Consider expanding the interface for a complete authentication flow.

The LoginScreenProps interface currently only includes onLogin. For a production-ready login screen, consider adding:

error?: string for displaying authentication errors

loading?: boolean for showing a loading state during authentication

onSignUp?: () => void for navigation to registration

onForgotPassword?: () => void for password recovery

33-53: Enhance accessibility and user feedback.

Consider adding the following improvements:

accessibilityLabel props for screen readers

Error message display below inputs when validation fails

Email format validation with visual feedback

Password strength indicator (if applicable)

Example for accessibility:
<TextInput
  style={styles.input}
  placeholder="email@example.com"
  placeholderTextColor="#888"
  value={email}
  onChangeText={setEmail}
  autoCapitalize="none"
  keyboardType="email-address"
  accessibilityLabel="メールアドレス入力フィールド"
/>
frontend/services/shared/use-theme-color.ts (1)
6-21: Prefer explicit return type on exported hook (: string).
Guidelines ask for explicit return types on exported functions; this always returns a color string.
 export function useThemeColor(
   props: { light?: string; dark?: string },
   colorName: keyof typeof Colors.light & keyof typeof Colors.dark
-) {
+): string {
   const theme = useColorScheme() ?? 'light'
   const colorFromProps = props[theme]
frontend/components/themed-view.tsx (1)
1-22: Prefer explicit return type on exported component.
 import { View, type ViewProps } from 'react-native'
+import type React from 'react'

 export function ThemedView({
   style,
   lightColor,
   darkColor,
   ...otherProps
-}: ThemedViewProps) {
+}: ThemedViewProps): React.JSX.Element {
   const backgroundColor = useThemeColor(
     { light: lightColor, dark: darkColor },
     'background'
   )
frontend/services/auth/signin.ts (1)
49-49: Consider adding proper error tracking for production.

The current implementation uses console.error for logging, which may not be monitored in production environments.

For production readiness, consider integrating an error tracking service:
// Example with Sentry or similar service
import * as Sentry from '@sentry/react-native'

// Replace console.error with:
Sentry.captureException(new Error('認証エラー'), {
  extra: { authError },
})
Also applies to: 66-66, 78-78

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a4df5d and 9dac29c.

⛔ Files ignored due to path filters (1)

frontend/bun.lock is excluded by !**/*.lock

📒 Files selected for processing (19)

frontend/app.json (2 hunks)
frontend/app/(tabs)/_layout.tsx (0 hunks)
frontend/app/(tabs)/explore.tsx (0 hunks)
frontend/app/_layout.tsx (2 hunks)
frontend/app/index.tsx (2 hunks)
frontend/components/login-screen.tsx (1 hunks)
frontend/components/parallax-scroll-view.tsx (1 hunks)
frontend/components/themed-text.tsx (1 hunks)
frontend/components/themed-view.tsx (1 hunks)
frontend/components/ui/collapsible.tsx (1 hunks)
frontend/entities/game/mode.ts (1 hunks)
frontend/entities/shared/formik.ts (1 hunks)
frontend/entities/users/users.ts (1 hunks)
frontend/package.json (2 hunks)
frontend/services/auth/create-user.ts (1 hunks)
frontend/services/auth/session.ts (1 hunks)
frontend/services/auth/signin.ts (1 hunks)
frontend/services/database/supabase.ts (1 hunks)
frontend/services/shared/use-theme-color.ts (1 hunks)

💤 Files with no reviewable changes (2)

frontend/app/(tabs)/explore.tsx
frontend/app/(tabs)/_layout.tsx

🧰 Additional context used

📓 Path-based instructions (5)

frontend/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

frontend/**/*.{ts,tsx}: Frontend Expo Router screens live under frontend/app/ (e.g., frontend/app/(tabs)/_layout.tsx), shared UI in frontend/components/ and frontend/components/ui/, assets in frontend/assets/images/, and utilities/hooks in frontend/hooks/ and frontend/constants/
Expo SDK 54 is in use; match the documented Node/Java versions for native tooling

Files:

frontend/entities/users/users.ts
frontend/components/themed-text.tsx
frontend/entities/game/mode.ts
frontend/components/parallax-scroll-view.tsx
frontend/services/auth/session.ts
frontend/services/auth/signin.ts
frontend/services/auth/create-user.ts
frontend/services/shared/use-theme-color.ts
frontend/entities/shared/formik.ts
frontend/app/_layout.tsx
frontend/services/database/supabase.ts
frontend/components/login-screen.tsx
frontend/components/themed-view.tsx
frontend/components/ui/collapsible.tsx
frontend/app/index.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript; prefer explicit return types on exported functions and components

Files:

frontend/entities/users/users.ts
frontend/components/themed-text.tsx
frontend/entities/game/mode.ts
frontend/components/parallax-scroll-view.tsx
frontend/services/auth/session.ts
frontend/services/auth/signin.ts
frontend/services/auth/create-user.ts
frontend/services/shared/use-theme-color.ts
frontend/entities/shared/formik.ts
frontend/app/_layout.tsx
frontend/services/database/supabase.ts
frontend/components/login-screen.tsx
frontend/components/themed-view.tsx
frontend/components/ui/collapsible.tsx
frontend/app/index.tsx

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use 2-space indentation, single quotes, and trailing commas per ESLint/Prettier defaults

Files:

frontend/entities/users/users.ts
frontend/components/themed-text.tsx
frontend/entities/game/mode.ts
frontend/components/parallax-scroll-view.tsx
frontend/services/auth/session.ts
frontend/services/auth/signin.ts
frontend/services/auth/create-user.ts
frontend/services/shared/use-theme-color.ts
frontend/entities/shared/formik.ts
frontend/app/_layout.tsx
frontend/services/database/supabase.ts
frontend/components/login-screen.tsx
frontend/components/themed-view.tsx
frontend/components/ui/collapsible.tsx
frontend/app/index.tsx

**/*.tsx

📄 CodeRabbit inference engine (AGENTS.md)

React components: Use PascalCase filenames (e.g., HelloWave.tsx)

Files:

frontend/components/themed-text.tsx
frontend/components/parallax-scroll-view.tsx
frontend/app/_layout.tsx
frontend/components/login-screen.tsx
frontend/components/themed-view.tsx
frontend/components/ui/collapsible.tsx
frontend/app/index.tsx

frontend/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Route files must follow Expo Router patterns (e.g., app/modal.tsx)

Files:

frontend/app/_layout.tsx
frontend/app/index.tsx

🧠 Learnings (6)

📚 Learning: 2025-12-08T15:54:59.341Z

Learnt from: CR
Repo: befoafsuger/rizap2025 PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T15:54:59.341Z
Learning: Applies to frontend/**/*.{ts,tsx} : Frontend Expo Router screens live under `frontend/app/` (e.g., `frontend/app/(tabs)/_layout.tsx`), shared UI in `frontend/components/` and `frontend/components/ui/`, assets in `frontend/assets/images/`, and utilities/hooks in `frontend/hooks/` and `frontend/constants/`

Applied to files:

frontend/components/parallax-scroll-view.tsx
frontend/app/_layout.tsx
frontend/components/login-screen.tsx
frontend/package.json
frontend/app/index.tsx

📚 Learning: 2025-12-08T15:54:59.341Z

Learnt from: CR
Repo: befoafsuger/rizap2025 PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T15:54:59.341Z
Learning: Applies to **/{hooks,*/hooks}/**/*.{ts,tsx} : Hooks must start with `use...` prefix

Applied to files:

frontend/services/auth/session.ts
frontend/services/auth/signin.ts
frontend/services/auth/create-user.ts
frontend/services/shared/use-theme-color.ts

📚 Learning: 2025-12-08T15:54:59.341Z

Learnt from: CR
Repo: befoafsuger/rizap2025 PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T15:54:59.341Z
Learning: Applies to **/*.{ts,tsx} : Use TypeScript; prefer explicit return types on exported functions and components

Applied to files:

frontend/entities/shared/formik.ts

📚 Learning: 2025-12-08T15:54:59.341Z

Learnt from: CR
Repo: befoafsuger/rizap2025 PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T15:54:59.341Z
Learning: Applies to frontend/**/*.{ts,tsx} : Expo SDK 54 is in use; match the documented Node/Java versions for native tooling

Applied to files:

frontend/app/_layout.tsx
frontend/package.json

📚 Learning: 2025-12-08T15:54:59.341Z

Learnt from: CR
Repo: befoafsuger/rizap2025 PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T15:54:59.341Z
Learning: Applies to frontend/app/**/*.{ts,tsx} : Route files must follow Expo Router patterns (e.g., `app/modal.tsx`)

Applied to files:

frontend/app/_layout.tsx

📚 Learning: 2025-12-08T15:54:59.341Z

Learnt from: CR
Repo: befoafsuger/rizap2025 PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T15:54:59.341Z
Learning: Frontend: from `frontend/`, run `npm install` then `npm run start` (Expo dev server), or platform targets via `npm run ios` / `npm run android` / `npm run web`. `npm run lint` uses Expo's ESLint preset. `npm run reset-project` wipes starter code—use cautiously.

Applied to files:

frontend/package.json

🧬 Code graph analysis (4)

frontend/services/auth/session.ts (1)

frontend/services/database/supabase.ts (1)

supabase (9-17)

frontend/services/auth/signin.ts (4)

frontend/entities/shared/formik.ts (1)

FormikReturnType (3-5)

frontend/utils/api.ts (1)

createUser (27-46)

frontend/services/auth/create-user.ts (1)

useCreateUser (16-48)

frontend/services/database/supabase.ts (1)

supabase (9-17)

frontend/services/auth/create-user.ts (2)

frontend/entities/users/users.ts (1)

createUserResponse (1-6)

frontend/utils/api.ts (1)

createUser (27-46)

frontend/app/index.tsx (1)

frontend/components/login-screen.tsx (1)

LoginScreen (14-70)

🪛 GitHub Actions: Lint and Format

frontend/entities/users/users.ts