Fix HF tokenization padding API + switch to torch AdamW#19
Open
Ishitaa7 wants to merge 1 commit intobehavioral-data:masterfrom
Open
Fix HF tokenization padding API + switch to torch AdamW#19Ishitaa7 wants to merge 1 commit intobehavioral-data:masterfrom
Ishitaa7 wants to merge 1 commit intobehavioral-data:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for your work. It’s been very helpful. While trying to use it, I ran into a few issues caused by outdated Hugging Face API usage, so this PR makes small compatibility fixes.
Specifically, it updates RoBERTa tokenization calls to the current HF Transformers API by replacing deprecated
pad_to_max_length/return_attention_masksarguments withpadding='max_length',return_attention_mask=True, andtruncation=Truewhere appropriate. It also replacestransformers.AdamWwithtorch.optim.AdamW, which is the currently recommended optimizer path.These changes are purely for maintaining compatibility with recent library versions.