fix: typing issue raising warnings in mypy and pylance#118
fix: typing issue raising warnings in mypy and pylance#118qherreros wants to merge 1 commit intobeir-cellar:mainfrom
Conversation
|
There are a number of type related issues. For instance, while the annotation for All the issues that I've encountered while using Is this a library that the original developers wish to maintain and keep active, or is this more of an exposition of the original paper? A tool like this could be quite useful in general, but it would need to be properly maintained. I don't necessarily mind putting in some effort to make fixes, but not if the repo owners don't care that much. |
|
Hi @nathan-chappell, It has been a busy past few months in my PhD and my part-time internship, so sadly I haven't gotten time to get back to recent changes for the BEIR repository. I do very much care about the repository and I try to maintain the BEIR repository as much as I can. I'm currently the only developer and the repository has been in a stale state for the past 6-8 months I would say. I would appreciate the help, if you can propose a PR by introducing the type errors. I will check in your PR to fix the type issues. |
|
@thakur-nandan Good luck with your PhD! |
Hello,
Currently, static type checker are raising multiple warnings because of the use of Type[] is some places of the code.
My understanding is that Type[] refers to the type of the type and not the type of the object, which explains warnings.
It's a very small problem that doesn't impact anything, apart from type checker.
Thanks for you work.