-
Notifications
You must be signed in to change notification settings - Fork 14
Add gated ε-serde and mem_dbg support #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Sorry, I've only just found the time to review this PR. My remarks and questions:
Since I am not a user of mem_dbg and epserde myself, I am wondering how all this should be done so that I can somehow maintain it. |
|
|
I completely removed As for It is possible to gate two versions of all involved structures. That, however, would mean to have 5 alternate versions, which starts to be significant code. In the non-ε-serde version, I understand that the addition of the parameters looks invasive (but note that there is no structural change). On the other hand, I think you need to have some efficient serialization mechanism, or your code can only be used for benchmarking. We developed ε-serde because we build this kind of maps for dozen of billions of items, and we need store to memory-map them, or load them in memory at high speed. We're presently using |
|
Hello @vigna ! I'm one of the others interested in serialization. But I'm surprised your branch didn't move after you last two comments ? could you push it without the hardcoded |
|
I was expecting an answer from @beling , but if there's interest I'll do it today. |
|
Oh wait. The path should already be ok. There's something wrong... |
|
Ok, there was a missing push. |
|
Thanks ! My tests on your branch are very positive towards using Phast+. The ability to store/load the MPH unlocks my current work on distributing large-scale archive containers. Looking forward to this PR 🤞 |
|
Yeah, it's a great data structure. We are now in the hands of @beling 😂. |
This PR adds Phast support for serialization and memory mapping with ε-serde, and inspection via
mem_dbg. The two features are namedepserdeandmem_dbg.