Merged
Conversation
.gitignore
Outdated
Contributor
There was a problem hiding this comment.
вместо этих строк можно написать одну /*.tmpl-specs/
Author
There was a problem hiding this comment.
есть директория, которая нужна, поэтому так
Contributor
|
ты уверен, что второй коммит тут уместен? Оформи его отдельным PR'ом |
common.blocks/image/image.deps.js
Outdated
Contributor
There was a problem hiding this comment.
это уже добавлено в https://github.com/bem/bem-components/pull/763/files
lapinlapin
changed the title
Member
|
Петь, добавь конструкцию "Close" с номером issue в описание пул-реквеста |
Contributor
|
ok |
Member
|
Все ок. |
gela-d
pushed a commit
that referenced
this pull request
Jul 23, 2014
image: Write tests on templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
вливать после #762
Close #760