Merged
Conversation
Member
|
лучше именовать файлы |
Author
|
хорошо, поправлю |
Member
There was a problem hiding this comment.
0 передавать не строкой, а числом
Member
|
Не хватает примера с урлом, в котором есть bemjson |
Member
|
В остальном все ок. |
Contributor
There was a problem hiding this comment.
исправь на 1, т.к. ноль - это значение по умолчанию
Author
|
Все поправил |
Contributor
There was a problem hiding this comment.
давай проверять эскейпинг - замени url на "url" : "//ya.ru/yandsearch?text=<script type=\"javascript\">&=test"
Author
Contributor
|
ok |
Member
There was a problem hiding this comment.
Я бы тут убрала табиндекс для проверки https://github.com/bem/bem-components/blob/v2/common.blocks/link/link.bemhtml#L26
Member
|
Все ок. |
gela-d
pushed a commit
that referenced
this pull request
Jul 23, 2014
link: Write tests on templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #770