perf(gulp-bem-src): cache level introspection #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birhoff
reviewed
Mar 25, 2018
| // try-catch optimization | ||
| function tryCatch(tryFn, catchFn) { | ||
| try { | ||
| tryFn(); |
There was a problem hiding this comment.
Lets test, I think it may not catch async functions
There was a problem hiding this comment.
It wont' catch throws in callbacks, but will catch async functions afair.
birhoff
reviewed
Mar 25, 2018
| * @param {*} bemConfig | ||
| * @returns {Introspection} | ||
| */ | ||
| module.exports = async (levelPaths, bemConfig, { cache=false } = {}) => { |
There was a problem hiding this comment.
JSDoc doesn't has options and cache description.
birhoff
reviewed
Mar 25, 2018
|
|
||
| const introspect = introspectLevel(levelPath, bemConfig); | ||
|
|
||
| levelCache[levelPath] = introspect; |
There was a problem hiding this comment.
Lets invert if.
Let save in cache with cache=true, and read always if exists
qfox
reviewed
Mar 25, 2018
| } | ||
| })) | ||
| .on('error', reject) | ||
| .on('finish', () => resolve(entityMap)); |
birhoff
reviewed
Mar 25, 2018
| * @param {Object} entity | ||
| * @returns {Iterator} | ||
| */ | ||
| *entityFiles(entity) { |
birhoff
reviewed
Mar 25, 2018
| "vinyl": "2.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@bem/sdk.naming.entity.parse": "^0.2.4", | ||
| "@bem/sdk.naming.presets": "^0.0.7" | ||
| "@bem/sdk.naming.presets": "^0.0.7", | ||
| "stream-to-array": "2.3.0" |
There was a problem hiding this comment.
крышечки долой, гринкипер в помощь
qfox
reviewed
Mar 25, 2018
| entityFiles.add(file); | ||
| } | ||
|
|
||
| opts.introspection = new Introspection(['<level-path>'], [entityMap]); |
|
Судя по тому, что я вижу, просел профицит, надо понять где мы теряем время, это лучше, чем было, но в gulp-bem/gulp-bem-src#23 в 4 раза быстрее. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.