start towards supporting an awaiter

[dietmarkuehl]

No description provided.

[JeffGarland]

should this be qualified std::unreachable?

[dietmarkuehl]

No, there is an "unreachable" function above which deals with some clang-tidy-warnings about assert always failing: that's the point - the function shouldn't be called and if it is I want it to fail.

[JeffGarland]

of course the function was hidden by the review tool -- you've already merged, but I'd suggest a different name when you're in there again. I was expecting a runtime check (since that's what std::unreachable is) - this is more like 'unexpected_call_assert'

[dietmarkuehl]

I'll make this change on the PR for task (I just made the change but there is more to go into the PR).

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	this->parent = ::std::move(parent);
	this->parent = ::std::move(parent);

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	return this->no_completion_set()
	? this->handle_stopped(this->parent.address())
	: ::std::move(this->parent)
	;
	return this->no_completion_set() ? this->handle_stopped(this->parent.address()) : ::std::move(this->parent);

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	auto (*handle_stopped)(void*)noexcept -> ::std::coroutine_handle<> = nullptr;
	auto (*handle_stopped)(void*) noexcept -> ::std::coroutine_handle<> = nullptr;

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	std::coroutine_handle<> unhandled_stopped() {
	return this->get_state()->complete();
	}
	std::coroutine_handle<> unhandled_stopped() { return this->get_state()->complete(); }

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	::beman::task::detail::sub_visit<2u>([]<typename E>(E& error) {
	if constexpr (::std::same_as<::std::remove_cvref_t<E>, ::std::exception_ptr>)
	std::rethrow_exception(::std::move(error));
	else
	throw ::std::move(error);
	}, this->result);
	::beman::task::detail::sub_visit<2u>(
	[]<typename E>(E& error) {
	if constexpr (::std::same_as<::std::remove_cvref_t<E>, ::std::exception_ptr>)
	std::rethrow_exception(::std::move(error));
	else
	throw ::std::move(error);
	},
	this->result);

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	}

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	}
	auto test_cancel() {
	auto rc = ex::sync_wait([]() -> ex::task<> {
	bool stopped{};
	co_await (
	[]()->ex::task<void> { co_await ex::just_stopped(); }()
	| ex::upon_stopped([&stopped]() { stopped = true; })
	);
	assert(stopped);
	}());
	}
	auto test_cancel() {
	auto rc = ex::sync_wait([]() -> ex::task<> {
	bool stopped{};
	co_await ([]() -> ex::task<void> { co_await ex::just_stopped(); }() |
	ex::upon_stopped([&stopped]() { stopped = true; }));
	assert(stopped);
	}());
	}

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	auto test_indirect_cancel() {
	// This approach uses symmetric transfer
	auto rc = ex::sync_wait([]() -> ex::task<> {
	std::cout << "indirect cancel\n" << std::unitbuf;
	bool stopped{};
	std::cout << "outer co_await\n";
	co_await (
	[]()->ex::task<void> {
	std::cout << "middle co_await\n";
	co_await []()->ex::task<void> {
	std::cout << "inner stopping\n";
	co_await ex::just_stopped();
	std::cout << "inner after stopped\n";
	}();
	std::cout << "middle after co_await\n";
	}()
	| ex::upon_stopped([&stopped]() { stopped = true; })
	);
	std::cout << "outer after co_await\n";
	assert(stopped);
	}());
	}
	auto test_indirect_cancel() {
	// This approach uses symmetric transfer
	auto rc = ex::sync_wait([]() -> ex::task<> {
	std::cout << "indirect cancel\n" << std::unitbuf;
	bool stopped{};
	std::cout << "outer co_await\n";
	co_await ([]() -> ex::task<void> {
	std::cout << "middle co_await\n";
	co_await []() -> ex::task<void> {
	std::cout << "inner stopping\n";
	co_await ex::just_stopped();
	std::cout << "inner after stopped\n";
	}();
	std::cout << "middle after co_await\n";
	}() | ex::upon_stopped([&stopped]() { stopped = true; }));
	std::cout << "outer after co_await\n";
	assert(stopped);
	}());

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	} // namespace

[github-actions]

[pre-commit] _{reported by reviewdog 🐶}

Suggested change

	auto main() -> int{
	auto main() -> int {