Pull from Philips Hue #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Applied file formatting length of 80 characters
* Make operator == override parameters no-nullable. See dart-lang/linter#3441 Work towards dart-lang/sdk#51038.
* Update dependencies, set ruby version and run codegen * Add IsConnectable support for Android and iOS * iOS Project updates * Set melos to fixed version * Add tests * Keep bledata protos number in order --------- Co-authored-by: RutgerVromans <[email protected]>
Co-authored-by: RutgerVromans <[email protected]>
…757) Co-authored-by: RutgerVromans <[email protected]>
* Bumps to Dart 2.17 minimum and upgrades melos to 3.1.0 * Update root pubspec.yaml with the correct workspace name Co-authored-by: Taym Haddadi <[email protected]> * add missing underscore --------- Co-authored-by: Taym Haddadi <[email protected]>
* Allow multiple services/characteristics of the same type on iOS * Allow multiple services/characteristics of the same type on Android * Update example to use new interface * Rename QualifiedCharacteristic to CharacteristicInstance to match Dart * Extend documentation * Update and extend tests * Address review comments * Update Kotlin tests --------- Co-authored-by: Sander Kersten <[email protected]>
Co-authored-by: Sander Kersten <[email protected]>
…f plugin (#830) * chore: Migrate to latest Android SDK, AGP and protobuf plugin * Remove unused files * Bumps to Dart 2.17 minimum and upgrades melos to 3.1.0 (#762) * Bumps to Dart 2.17 minimum and upgrades melos to 3.1.0 * Update root pubspec.yaml with the correct workspace name * Add GitHub actions Co-authored-by: Taym Haddadi <[email protected]> Co-authored-by: Sebastian Roth <[email protected]>
* Migrate away from deprecated strong-mode analysis options --------- Co-authored-by: Parker Lougheed <[email protected]>
* Read RSSI of connected device * Kotlin style issues * Address review comments and add tests --------- Co-authored-by: Tyler Norbury <[email protected]> Co-authored-by: Sander Kersten <[email protected]>
* Use proper platform_interface dependency * Update pubspec.yaml
Signed-off-by: Taym <[email protected]>
* ktlint again * re-add ktlint action * address warnings * editor config file
* Bump dependencies * remove unused files * add ios example gitignore * upgrade a few test dependencies * adjust workflow * upgrade detekt.yml syntax * update detekt config / minimal formatting adjustments * re-run ios packaging
…eam leaking (#876) - Previous code would create a broadcastStream from a normal stream (created by Repeater). When this is done, the source stream subscription needs to be explicitly closed. This is usually done by implementing the onCancel callback from the asBroadcastStream method. This was not happening, so every call to connectedDeviceStream was creating a new subscription that was never closed. - To fix the problem, this commit uses the Repeater.broadcast constructor which already returns a broadcast stream and also closes the source stream subscription when needed
* Implement MacOS support using sharedDarwinSource * Update protobuf docs * Fix compilation and warnings --------- Co-authored-by: Rohit Sangwan <[email protected]>
…eprecated imperative apply of gradle plugins (#871)
… stream transformation so the stack trace is the one for the call to readCharacteristic (ending in the user's code that initiated the read that failed) instead of some generic list of stream handling methods.
Improve stack trace of exceptions from read(Characteristic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.