Move source location of the .env file to the root at the project #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rragundez
changed the title
rragundez
force-pushed
the
env-to-root
branch
from
3d22c75 to
d5249a0
Compare
rragundez
changed the title
rragundez
force-pushed
the
env-to-root
branch
from
d5249a0 to
54279f0
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the .env file is sourced from inside the
srcdirectory, it should not be part of the code is best practice to make it part of the top level of the project. This PR makes the changes such that all scripts respect that, including the sourcing of the file from the source code.There are a couple of benefits to doing this, like better visibility, separation of concerns between code functionality and dynamic configuration settings, and help the easy transition between using an .env file and environment variables set before runtime.