Use new statistex to actually do outlier detection and removal #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragTob
force-pushed
the
outlier-decection-removal
branch
from
89d5807 to
f91ba84
Compare
Member
Author
|
Sigh, looks like my pattern is "go to funeral, couple of days do OSS, then get stressed and forgot about OSS again". Trying to wrap this up to get in a release before 1.19 and finally have all these features. |
PragTob
force-pushed
the
outlier-decection-removal
branch
from
f91ba84 to
6d42108
Compare
Calculates more percentiles now, that is an acceptable upgrade side effect. We want to use the new outlier functionality, so depending on the new version is required/
Seems to all work fine. But do add a test - although I figure that one will be hard to do "properly".
PragTob
force-pushed
the
outlier-decection-removal
branch
from
6d42108 to
87b1697
Compare
Away from calling them run times (we got multiple now) and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest thanks goes to @NickNeck for his work over in Statistex bencheeorg/statistex#5
I'm not sure yet how/if to display the outliers or outlier bounds in the normal report, maybe at max in the extended statistics report (and there could be many) - might be its own feature.
But goal is to provide an option, that should be visible when we print the configuration summary, that removes outliers.