Add Fluid templates for EXT:felogin #1260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
approved these changes
Apr 7, 2023
Contributor
linawolf
left a comment
linawolf
left a comment
There was a problem hiding this comment.
These changes work great in my project where I just updated from TYPO3 v10.4 to 11.5
Owner
|
We cannot take this patch in, v12 has changed templates, that also set attributes on view helpers that do not exist in v11. |
benjaminkott
requested changes
Apr 25, 2023
Owner
benjaminkott
left a comment
benjaminkott
left a comment
There was a problem hiding this comment.
We cannot handle login templates, by default since we maintain compact with 2 LTS versions.
Owner
|
still same remarks, merged the changes to a single patchset for easier rebase |
Owner
|
We keep the patch around till we drop support for v11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issues
Prerequisites
Description
As EXT:felogin is available as Extbase plugin using Fluid templates since Typo3 v10.2 (https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.2/Feature-88102-FrontendLoginViaFluidAndExtbase.html) EXT:bootstrap_package should provide templates for it. The templates are based on the old one for the PiBase plugin.
Steps to Validate