[BUGFIX] Respect carousel type specific responsive image settings#1552
Merged
benjaminkott merged 2 commits intobenjaminkott:masterfrom Mar 26, 2025
Merged
[BUGFIX] Respect carousel type specific responsive image settings#1552benjaminkott merged 2 commits intobenjaminkott:masterfrom
benjaminkott merged 2 commits intobenjaminkott:masterfrom
Conversation
Owner
|
@Jaykju thx for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Prerequisites
php-cs-fixer fixcd Build; npm ci; npm run build)Description
The current configuration only respects responsive image settings for the background_image field set for the
CarouselContent-Element, even ifCarousel-FullscreenorCarousel-Smallare used.Steps to Validate
Carousel-Fullscreencontent element to a pagebackground_imageto that itemcarouselis used here.bootstrap_package/Resources/Private/Partials/ContentElements/Carousel/General/BackgroundImage.html
Line 12 in ea0b95f