Skip to content

Comments

[BUGFIX] Respect carousel type specific responsive image settings#1552

Merged
benjaminkott merged 2 commits intobenjaminkott:masterfrom
Jaykju:master
Mar 26, 2025
Merged

[BUGFIX] Respect carousel type specific responsive image settings#1552
benjaminkott merged 2 commits intobenjaminkott:masterfrom
Jaykju:master

Conversation

@Jaykju
Copy link
Contributor

@Jaykju Jaykju commented Mar 7, 2025

Pull Request

Prerequisites

  • Changes have been tested on TYPO3 v11.5 LTS
  • Changes have been tested on TYPO3 v12.4 LTS
  • Changes have been tested on TYPO3 v13.4 LTS
  • Changes have been tested on PHP 7.4
  • Changes have been tested on PHP 8.0
  • Changes have been tested on PHP 8.1
  • Changes have been tested on PHP 8.2
  • Changes have been tested on PHP 8.3
  • Changes have been checked for CGL compliance php-cs-fixer fix
  • CSS has been rebuilt (only if there are SCSS changes cd Build; npm ci; npm run build)

Description

The current configuration only respects responsive image settings for the background_image field set for the Carousel Content-Element, even if Carousel-Fullscreen or Carousel-Small are used.

Steps to Validate

  1. Add a Carousel-Fullscreen content element to a page
  2. Add an item
  3. Add a background_image to that item
  4. Change the responsive image settings in your typoscript setup:
    lib.contentElement.settings.responsiveimages.contentelements {
        carousel_fullscreen {
            background_image {
                multiplier {
                    medium = 0.1       
                }
            }
        }
    }
    
  5. The processed image won't change because the setting for carousel is used here.

<f:variable name="imageConfig">{settings.responsiveimages.contentelements.carousel.background_image}</f:variable>

@benjaminkott benjaminkott merged commit 17a9092 into benjaminkott:master Mar 26, 2025
6 checks passed
benjaminkott added a commit that referenced this pull request Mar 26, 2025
)

Co-authored-by: Benjamin Kott <benjamin.kott@outlook.com>
@benjaminkott
Copy link
Owner

@Jaykju thx for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants