Skip to content

Add "implements" to DeclareClass, for Flow declare class #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "implements" to DeclareClass, for Flow declare class #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion def/flow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,8 @@ export default function (fork: Fork) {

def("DeclareClass")
.bases("InterfaceDeclaration")
.build("id");
.build("id")
.field("implements", [def("ClassImplements")], defaults.emptyArray);

def("DeclareModule")
.bases("Statement")
Expand Down
1 change: 1 addition & 0 deletions gen/builders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2294,6 +2294,7 @@ export interface DeclareClassBuilder {
comments?: K.CommentKind[] | null,
extends: K.InterfaceExtendsKind[],
id: K.IdentifierKind,
implements?: K.ClassImplementsKind[],
loc?: K.SourceLocationKind | null,
typeParameters?: K.TypeParameterDeclarationKind | null
}
Expand Down
1 change: 1 addition & 0 deletions gen/namedTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,6 +1055,7 @@ export namespace namedTypes {

export interface DeclareClass extends Omit<InterfaceDeclaration, "type"> {
type: "DeclareClass";
implements?: K.ClassImplementsKind[];
}

export interface DeclareModule extends Omit<Statement, "type"> {
Expand Down