Merged
Conversation
- Uses the release tag of ahk2exe to find the correct BinMod.ahk to
download
* This file is not bundled with the release, so we need to dig a bit
more to download it directly from the source tree
* Determining the 'latest' tag requires an additional request (as we
need the actual tag name to retrieve BinMod.ahk)
- Install BinMode.exe along side ahk2exe and upx (where it's expected to
be)
- Use shared function for getting release information - Check for previously installed BinMod - Validate BinMod compilation - Add tests
Owner
|
@haata Overall looked good.
|
Contributor
Author
|
Nah, I think you're revisions look great (I'm mostly just guessing when it comes to Powershell 😆 ). As for usages of BinMod, I think that should be sufficient. Really just need something that calls BinMod.exe, the functionality of BinMod is less important as that may change per release. Thanks a bunch for cleaning it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (#14)
Retrieves BinMod.ahk and compiles (using Ahk2Exe) from the same sha as the ahk2exe release selected.
Doesn't require any configuration (this is done in code using
;@Ahk2Exec-PostExec, see https://www.autohotkey.com/docs/v2/misc/Ahk2ExeDirectives.htm#PostExec).https://github.com/AutoHotkey/Ahk2Exe/blob/master/BinMod.ahk