Skip to content

arbiter: Wait for all old workers to terminate on SIGHUP #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

arbiter: Wait for all old workers to terminate on SIGHUP #3312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions gunicorn/arbiter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,13 +478,23 @@ def reload(self):
# set new proc_name
util._setproctitle("master [%s]" % self.proc_name)

last_worker_to_kill = self.worker_age

# spawn new workers
for _ in range(self.cfg.workers):
self.spawn_worker()

# manage workers
self.manage_workers()

# wait for all old workers to be replaced
deadline = time.monotonic() + self.cfg.graceful_timeout
while time.monotonic() < deadline:
oldest_worker = list(self.WORKERS.values())[0].age
if oldest_worker > last_worker_to_kill:
break
time.sleep(0.1)

def murder_workers(self):
"""\
Kill unused/idle workers
Expand Down