-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add more systemd notifications #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I submitted a very similar patch as part of #3285 which is only slightly different:
|
| [Service] | ||
| # gunicorn can let systemd know when it is ready | ||
| Type=notify | ||
| Type=notify-reload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info, I updated the PR to explain this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines starting with # are comments in systemd. (Please keep up expecting software to be designed with common conventions in mind! That - reasonable - expectation is what keeps is from straying further into "surprise feature" territory.)
93d8eec to
3f9446f
Compare
Avoid the use of 'ExecReload' as advised in systemd.service(5)
3f9446f to
25a31e7
Compare
Type=notify-reloadand removeExecReloadin the systemd unit