Reset cursor on page change or category change#111
Reset cursor on page change or category change#111f01c33 wants to merge 2 commits intobensadeh:mainfrom
Conversation
|
Hey @f01c33 and thanks for the PR! I think this makes sense for category change, but for the page change I like the behavior of having the cursor the same place. Would you be able to update the PR for this? |
|
Sure! |
|
Changes done @bensadeh, it wasn't working correctly inside the: if m.categoryHasStories(nextCat){So i changed it to be above, and now it works fine |
|
Thanks for updating it! I will have a look at as soon as I have the time, but the changes should be straightforward! |
|
Sorry this took a while to get back to! I just tried out the branch and there seems to be an issue when we change category the first time. On In your branch, the current page immediately goes blank. In other words, when we fetch a new category, the stories are now hidden instead of dimmed while waiting for the stories to fetch. |
Hi, so this is mainly a UX decision, of course, but i think the cursor should reset to 0 on page change or category change, it just makes more sense having a nice refresh on page changes, feel free to close if it does not make much sense to you :)