Fixes bensadeh/circumflex#137#138
Open
christiangoeschel wants to merge 2 commits intobensadeh:mainfrom
Open
Conversation
christiangoeschel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, currently when list items are distributed across multiple pages you can not traverse these when ( cursorIndex == len(listItems) - 1 ) or ( cursorIndex == 0 ) is hit and the user is trying to go further down or up.
This is unusual behavior given that modern UIs allow for a more free item selection, especially in the context of similar applications. Let me know your thoughts on this or simply close if this is trivial :D 👍🏽