fix: conversion warning in mul_hi64()

benthevining · benthevining · commit ba91a0ab8344 · 2026-03-11T00:25:01.000-05:00
diff --git a/libutil/src/MulHi64.cpp b/libutil/src/MulHi64.cpp
@@ -52,7 +52,10 @@ auto mul_hi64(
 {
     __extension__ using uint128_t = unsigned __int128;
 
-    return (static_cast<uint128_t>(first) * static_cast<uint128_t>(second)) >> UINT64_C(64);
+    const uint128_t prod = static_cast<uint128_t>(first) * static_cast<uint128_t>(second);
+
+    return static_cast<uint64_t>(
+        prod >> static_cast<uint128_t>(64));
 }
 
 } // namespace util::math

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,10 @@ auto mul_hi64(`
`52`	`52`	`{`
`53`	`53`	`__extension__ using uint128_t = unsigned __int128;`
`54`	`54`
`55`		`- return (static_cast<uint128_t>(first) * static_cast<uint128_t>(second)) >> UINT64_C(64);`
	`55`	`+ const uint128_t prod = static_cast<uint128_t>(first) * static_cast<uint128_t>(second);`
	`56`	`+`
	`57`	`+ return static_cast<uint64_t>(`
	`58`	`+ prod >> static_cast<uint128_t>(64));`
`56`	`59`	`}`
`57`	`60`
`58`	`61`	`} // namespace util::math`