Skip to content

Conversation

@bojiang
Copy link
Member

@bojiang bojiang commented Jan 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 23, 2026 06:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Helm-configurable toggle to enable “model eager download” behavior during S3-backed image builds, wiring the setting from chart values into the controller’s bento-image-builder invocation.

Changes:

  • Introduces global.modelEagerDownload in the yatai-image-builder Helm values.
  • Exposes the value as CONTAINER_IMAGE_MODEL_EAGER_DOWNLOAD via the chart’s env Secret.
  • Adds a Go env getter and conditionally appends --model-eager-download to the S3 image builder command flags.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
helm/yatai-image-builder/values.yaml Adds a configurable chart value to control model eager download behavior.
helm/yatai-image-builder/templates/secret-env.yaml Plumbs the new value into an env var consumed by the controller.
controllers/resources/bentorequest_controller.go Reads the env var and conditionally adds the corresponding CLI flag for S3 image builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants