Make Clock a generic parameter #51
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a
Clocktrait a generic parameter, allowing to use e.g.FakeRelativeClockin tests to avoid waiting.Public API gets
default_with_clock()method that allows creating a builder with a customClock.Clockdefaults toDefaultClockas before, so API shouldn't break, but since most of public types got additional generic parameter - some code that references them might break, so it's a breaking change.I'm not sure if it's possible to avoid that since
Clockgeneric parameter boils down toRateLimiterfromgovernorcrate andRateLimiterdoesn't expose any specific trait it seems so we can't justBox<dyn ...>it... maybe I am missing something here.Fixes #50