Cleaned up creating a path

Author: beproact

src/ButtonActionManager.hpp

@@ -74,7 +74,6 @@ class $modify(DifferentThing, CCMenuItemSpriteExtra){
     }
 
     void selected(){
-        log::debug("2");
         ButtonActionManager::get()->actions.selected(this);
     }
     void activate(){

src/NodeFinder.hpp

@@ -11,6 +11,21 @@ Node Path
 List of NodeAddresses
 array
 vector???
+*/
+/* 
+
+We need to have a map of top layer IDs to a list of paths along with callbacks.
+When run is called with a top layer, we check if there are any registered callbacks for that top layer.
+If there are, we go through each path and try to find the node.
+Then we call the callback with the found node (or nullptr if not found).
+
+This means we need a way to represent the path to a node or just the node ID and search recursively.
+
+sum types would be nice
+c++ has 
+copilot what the fuck why do you hate variants
+
+
 */
 
 //does this need to be a singleton can it just be a static class?

src/NodePath.hpp

@@ -19,7 +19,8 @@ struct NodeID {
     //     return os << ((p.idName != "") ? p.idName : std::to_string(p.idIndex));
     // }
     std::string to_string() {
-        return (idName != "") ? idName : std::format("num{}",idIndex);
+        //return (idName != "") ? idName : std::format("num{}",idIndex);
+        return std::format("{}[{}]", idName, idIndex);
     }
 
     bool operator< (const NodeID& other) const {        // why tf is this here 
@@ -50,11 +51,24 @@ struct NodePath {
         return result;
     }
 
-
-    static int getNumID(CCNode* node) {
+    // Gets index of node among its siblings with same
+    static int getNumID(CCNode* node)  {
+        std::string id = node->getID();
         auto parent = node->getParent();
-        auto siblings = parent->getChildren();
-        return siblings->indexOfObject(node);
+        auto siblings = parent->getChildrenExt(); //?????
+        //ext works with iterators
+        // std::vector<CCNode*> filtered;
+
+        // for (auto sibling : siblings) {
+        //     if (sibling->getID() == id) {
+        //         filtered.push_back(sibling);
+        //     }
+        // }
+
+        auto filtered = utils::ranges::filter(siblings, [id](CCNode* sibling){
+            return sibling->getID() == id;
+        });
+        return std::distance(filtered.begin(), std::find(filtered.begin(), filtered.end(), node)); // why is this what c++ does for indexOf
     }
 
     std::string to_string() {