Change: more sensible default and handling of ntype#27
Merged
huangziwei merged 6 commits intomainfrom Nov 26, 2025
Merged
Conversation
huangziwei
reviewed
Nov 26, 2025
skeliner/post.py
Outdated
| if ntype is None: | ||
| return None | ||
| mapped = np.full(new_len, 3, dtype=ntype.dtype) | ||
| mapped = np.full(new_len, 0, dtype=ntype.dtype) |
Collaborator
There was a problem hiding this comment.
so if we still do this, every post-processing steps will reset the existing ntype to 0.
we need to rethink how to remap ntype but preserve the existing ones.
on the other hand, in reroot, we do ntype[[0, swap]] = ntype[[swap, 0]], which is also too simple. maybe we should take edges into account also.
Contributor
Author
|
Tested on 2 skeletons. Works for plotting, rerooting, pruning and downsampling. |
ntype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ntyperemapping now aggregates labels when nodes merge (majority with a fixed priority), enforces a single root/soma, and fills zero gaps from neighboring labels.ntypeusing the new remap + gap-fill; reroot also fills gaps after clearing duplicate -1/1 labels.