add: plotting options,including rasterize#28
Merged
huangziwei merged 2 commits intomainfrom Jan 22, 2026
Merged
Conversation
huangziwei
reviewed
Jan 21, 2026
huangziwei
reviewed
Jan 21, 2026
| highlight_face_alpha=highlight_alpha, | ||
| **kwargs, | ||
| ) | ||
| return fig, ax |
Collaborator
There was a problem hiding this comment.
it's indeed ugly for jupyter that we return the figure object everytime, but with them we can still modify the aesthetics after the figure is generated, without rerunning everything. but I don't have a strong opinion on this.
Contributor
Author
There was a problem hiding this comment.
no, you are right. let's add this
Contributor
Author
There was a problem hiding this comment.
actually I'm confused, this was not removed by me, right? I think the return makes sense
Collaborator
There was a problem hiding this comment.
I don't know. The diff said the earlier version removed it.
Collaborator
|
Looks good! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested and seems to work fine.