Stop translating underscores in configure args#107
Open
runderwo wants to merge 2 commits intobernd:mainfrom
Open
Stop translating underscores in configure args#107runderwo wants to merge 2 commits intobernd:mainfrom
runderwo wants to merge 2 commits intobernd:mainfrom
Conversation
Owner
|
The translation was introduced as syntactic sugar so you can use You can use a regular string argument as a workaround though: See my example nginx recipe: https://github.com/bernd/fpm-recipes/blob/master/nginx/recipe.rb#L24-L29 Hope that helps. |
Author
|
If you're not going to fix it, then at least warn when you see an underscore in a configure argument and point to the recommended workaround. My workaround was: configure = './configure'
args.each do |k, v|
if v == true
configure += " --#{k}"
else
configure += " --#{k}=#{v}"
end
end
safesystem configure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks nginx configuration. See the configure arguments here:
https://github.com/nginx/nginx/blob/master/auto/options
Is there a good reason for this translation? Somehow the user didn't actually intend an underscore?