Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds the Claudie v0.10 changelog documenting manual upgrade prerequisites (Longhorn v1.9.2), removal of Builder/BuilderTTL, migration to a NATS-backed task system, a redesigned reconciliation/task flow with continuous health checks and auto-repair, OpenTofu-native locking replacing DynamoDB, feature updates (GCP GPU support, dynamic nodepool zones), and a mkdocs navigation entry. Changes
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Line 65: The changelog line containing "Preventing kubeone to override
`config.toml` which would collide with `NvidiaGPU` operator overrites" has a
typo: change "overrites" to "overwrites" so the sentence reads "...which would
collide with `NvidiaGPU` operator overwrites"; update that exact token in the
changelog entry text.
- Line 34: Fix the typo in the changelog sentence that reads "We provide
checksums in `claudie_checksum.txt` you can verify the downloaded yaml files
againts the provided checksums." — replace "againts" with "against" so the
sentence reads "...you can verify the downloaded yaml files against the provided
checksums." Reference the string `claudie_checksum.txt` to locate the line to
edit in the changelog entry.
- Line 73: The sentence in the changelog line about the `zone` field for dynamic
nodepools uses incorrect verb tense ("automatically distributed"); update the
sentence in changelog-0.10.x.md so it reads "If omitted claudie will
automatically distribute the nodes across zones" (preserve backticks and PR link
and keep `zone`, "dynamic nodepools", and "Input Manifest" as-is).
- Line 105: Fix the typo in the changelog sentence by replacing the misspelled
word "reconcilation" with "reconciliation" in the line that currently reads
"Part of the reconcilation loop is to refresh the current state infrastructure
periodically after no tasks has been identified
[`#1979`](https://github.com/berops/claudie/pull/1979)"; ensure the corrected
sentence reads "Part of the reconciliation loop..." and keep the rest of the
line and PR link unchanged.
- Around line 40-42: The fenced code blocks in the changelog lack language
specifiers which triggers markdownlint MD040; update the three code fences shown
(the kubectl command block and the YAML examples around the nodePools snippet)
by adding appropriate language tags (e.g., ```bash for the kubectl command and
```yaml for YAML blocks) so each fenced block includes a language specifier and
apply the same change to the other affected blocks mentioned (lines 83-97).
- Around line 14-16: Update the sentence "clusters build with `v0.9.16`" to use
the correct past participle "clusters built with `v0.9.16`" and replace the
non-descriptive link text
`[here](https://longhorn.io/docs/1.9.2/deploy/upgrade/#manual-checks-before-upgrade)`
with a descriptive label such as `[manual upgrade
steps](https://longhorn.io/docs/1.9.2/deploy/upgrade/#manual-checks-before-upgrade)`
(or `[manual checks before upgrade]`) so the line reads clearly and satisfies
markdownlint MD059.
- Line 61: The changelog line currently reads "Upgrade kubeone to v1.12.1.
Claudie now supports building the following kuberentes versions: `32,33,34` ..."
— fix it by changing the version list to the proper Kubernetes format and
correct the typo: replace the fragment `32,33,34` with `1.32, 1.33, 1.34`
(include spaces after commas) and change "kuberentes" to "kubernetes" so the
line becomes, for example, "Upgrade kubeone to v1.12.1. Claudie now supports
building the following kubernetes versions: `1.32, 1.33, 1.34`
[`#1913`](https://github.com/berops/claudie/pull/1913)".
Co-authored-by: Samuel Stolicny <stolicnysamuel@gmail.com>
Co-authored-by: Samuel Stolicny <stolicnysamuel@gmail.com>
samuelstolicny
approved these changes
Feb 18, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Line 109: Update the changelog entry text that currently reads "Deletion
process was fixed for newer versions of kubernetes
[`#1919`](https://github.com/berops/claudie/pull/1919)" to capitalize the proper
noun by replacing "kubernetes" with "Kubernetes" so the line reads "Deletion
process was fixed for newer versions of Kubernetes
[`#1919`](https://github.com/berops/claudie/pull/1919)"; locate the exact string
in the changelog (the entry under changelog-0.10.x) and make this single-word
capitalization change.
---
Duplicate comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Around line 83-97: The fenced YAML example for the nodePools snippet is
missing a language specifier; update the markdown code fence that precedes the
block containing "nodePools:" / "dynamic:" / "nvidiaGpuCount" to add the yaml
language tag (i.e., change the opening ``` to ```yaml) so the block is properly
highlighted and satisfies MD040.
- Line 61: Update the malformed Kubernetes version list in the changelog entry
that currently reads "Upgrade kubeone to v1.12.1. Claudie now supports building
the following kubernetes versions: `32,33,34` [`#1913`]": replace the backticked
`32,33,34` with properly prefixed and spaced versions such as `1.32, 1.33, 1.34`
(or individually backtick each version if preferred) so the entry reads e.g.
"…supports building the following Kubernetes versions: `1.32, 1.33, 1.34`
[`#1913`]".
- Around line 14-16: Fix the grammar and link text in the changelog entry:
change the phrase "clusters build with `v0.9.16`" to "clusters built with
`v0.9.16`" and replace the non-descriptive link text `[here]` with a descriptive
label such as `[manual upgrade steps]` for the Longhorn upgrade link; update the
sentence in the changelog-0.10.x.md content block that mentions Longhorn v1.9.2
so it reads with the corrected past participle and descriptive link text.
- Around line 40-42: The fenced code block in the changelog lacks a language
specifier (MD040); update the block that contains "kubectl apply -f
https://github.com/berops/claudie/releases/latest/download/claudie.yaml" by
adding a language identifier (e.g., bash) after the opening ``` so the block
becomes ```bash, ensuring the syntax highlight rule is satisfied for the snippet
in the changelog-0.10.x.md entry.
Member
|
With my OCD, can we pls |
bernardhalas
requested changes
Feb 18, 2026
Co-authored-by: Bernard Halas <bernard.halas@berops.com>
Co-authored-by: Bernard Halas <bernard.halas@berops.com>
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
docs/CHANGELOG/changelog-0.10.x.md (1)
29-29: Inconsistent version placeholder casing:v0.10.Xvsv0.10.xLine 29 uses uppercase
Xinv0.10.X; the rest of the document (e.g. lines 19, 25, 106) consistently uses lowercasex.✏️ Proposed fix
-To deploy Claudie `v0.10.X`, please: +To deploy Claudie `v0.10.x`, please:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/CHANGELOG/changelog-0.10.x.md` at line 29, Change the inconsistent version placeholder casing by replacing the uppercase `X` in the string "To deploy Claudie `v0.10.X`, please:" with a lowercase `x` so it matches the rest of the document (i.e., update `v0.10.X` to `v0.10.x`).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Around line 84-98: The YAML example uses invalid comment syntax ("<--") next
to nvidiaGpuCount and nvidiaGpuType; replace those inline annotations with
proper YAML comments using "#" (e.g., change "nvidiaGpuCount: 1 <--
specify number of gpus." to "nvidiaGpuCount: 1 # specify number of gpus." and
similarly for nvidiaGpuType) while preserving the existing keys (nodePools,
dynamic, gpu-workers, providerSpec, nvidiaGpuCount, nvidiaGpuType) and
indentation so the snippet remains valid YAML.
- Around line 15-16: Change the typo "build" to "built" in the sentence "For
existing clusters build with `v0.9.16`" so it reads "For existing clusters built
with `v0.9.16`"; locate that exact sentence in the changelog content and update
the word to "built".
- Line 17: Replace the non-canonical domain casing in the markdown links by
changing any occurrences of "https://Longhorn.io" to "https://longhorn.io"
(e.g., update the link text currently reading
"https://Longhorn.io/docs/1.9.2/deploy/upgrade/..." and the other repeated
occurrence) so both links use the all-lowercase canonical hostname.
- Line 62: Update the changelog entry that currently reads "Upgrade kubeone to
v1.12.1. Claudie now supports building the following Kubernetes versions:
`v1.32, v1.33, v1.34`" to explicitly document the rationale for continuing to
list `v1.32` (which reaches EOL on 2026-02-28)—for example, add a parenthetical
note that `v1.32` is retained to support long-term or legacy customers or
backport/compatibility reasons—and ensure you do not add `v1.35` since KubeOne
v1.12.1 does not support it; keep the wording concise and factual so readers
understand why an EOL version is still listed.
---
Nitpick comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Line 29: Change the inconsistent version placeholder casing by replacing the
uppercase `X` in the string "To deploy Claudie `v0.10.X`, please:" with a
lowercase `x` so it matches the rest of the document (i.e., update `v0.10.X` to
`v0.10.x`).
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Around line 100-102: Replace the incorrect phrase "as unreachable nodes" with
"such as unreachable nodes" in the changelog entry that starts with "Initial
version of the reconciliation loop was added to Claudie" so the sentence reads
"While currently this only resolves basic scenarios, such as unreachable nodes,
the aim is to broaden this with every release." Ensure only that phrasing is
updated and maintain the surrounding text and links.
- Line 25: The bullet "DynamoDB was removed in favor of native locking supported
by newer versions of OpenTofu which ship with Claudie `v0.10.x`" is missing a
terminal period—edit the line to append a full stop so it becomes
"...`v0.10.x`." to match the punctuation style of other bullets in the
changelog.
---
Duplicate comments:
In `@docs/CHANGELOG/changelog-0.10.x.md`:
- Around line 41-43: The fenced code block containing "kubectl apply -f
https://github.com/berops/claudie/releases/latest/download/Claudie.yaml" is
missing a language specifier; update the triple-backtick fence that wraps that
command to use a language tag (e.g., add "bash" after the opening ```), so it
becomes ```bash ... ``` to satisfy MD040 and ensure proper syntax highlighting.
- Around line 84-98: Add a language tag to the opening code fence (use ```yaml)
and update the inline comments for nvidiaGpuCount and nvidiaGpuType to use
proper acronym casing (“GPUs” and “GPU”); locate the YAML code block containing
nodePools → dynamic and edit the comments next to the nvidiaGpuCount and
nvidiaGpuType fields to read “# <-- specify number of GPUs.” and “# <-- specify
GPU type” respectively, and change the initial fence from ``` to ```yaml.
- Line 17: The link uses non-descriptive link text "[here]" (MD059); update the
markdown line containing "- Please read about the manual steps
[here](https://longhorn.io/docs/1.9.2/deploy/upgrade/#manual-checks-before-upgrade)"
to replace "[here]" with descriptive link text such as "manual checks before
upgrade" or "Longhorn manual checks before upgrade" so the link reads e.g. "-
Please read about the manual steps in the Longhorn manual checks before upgrade
(https...)" or "- Please read about the manual steps in the manual checks before
upgrade [manual checks before upgrade](https://...)" ensuring the link text
clearly describes the destination.
bernardhalas
approved these changes
Feb 18, 2026
Member
bernardhalas
left a comment
bernardhalas
left a comment
There was a problem hiding this comment.
Thanks for the modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit