Skip to content

Update generated helper, modifier and service names #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bertdeblock merged 1 commit into from
May 6, 2025
Merged

Update generated helper, modifier and service names #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/helper/class-based.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Helper from "@ember/component/helper";

export default class {{name.pascal}} extends Helper {
export default class {{name.camel}} extends Helper {
Copy link
Owner Author

@bertdeblock bertdeblock May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit weird to use camelCase for a class, but this seems to make more sense to me when using gts/gjs. Sames goes for modifiers.

compute(positional, named) {
return positional;
}
Expand Down
2 changes: 1 addition & 1 deletion templates/helper/class-based.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export interface {{name.signature}} {
Return: Return;
}

export default class {{name.pascal}} extends Helper<{{name.signature}}> {
export default class {{name.camel}} extends Helper<{{name.signature}}> {
compute(positional: Positional, named: Named): Return {
return positional;
}
Expand Down
2 changes: 1 addition & 1 deletion templates/modifier/class-based.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Modifier from "ember-modifier";

export default class {{name.pascal}} extends Modifier {
export default class {{name.camel}} extends Modifier {
modify(element, positional, named) {}
}
2 changes: 1 addition & 1 deletion templates/modifier/class-based.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ export interface {{name.signature}} {
Element: Element;
}

export default class {{name.pascal}} extends Modifier<{{name.signature}}> {
export default class {{name.camel}} extends Modifier<{{name.signature}}> {
modify(element: Element, positional: Positional, named: Named) {}
}
2 changes: 1 addition & 1 deletion templates/service/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import Service from "@ember/service";

export default class {{name.pascal}} extends Service {}
export default class {{name.pascal}}Service extends Service {}
4 changes: 2 additions & 2 deletions templates/service/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import Service from "@ember/service";

export default class {{name.pascal}} extends Service {}
export default class {{name.pascal}}Service extends Service {}

declare module "@ember/service" {
interface Registry {
"{{name.path}}": {{name.pascal}};
"{{name.path}}": {{name.pascal}}Service;
}
}
4 changes: 2 additions & 2 deletions test/__snapshots__/generate-helper.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`generates a class-based \`.js\` helper 1`] = `
"import Helper from "@ember/component/helper";

export default class Foo extends Helper {
export default class foo extends Helper {
compute(positional, named) {
return positional;
}
Expand All @@ -26,7 +26,7 @@ export interface FooSignature {
Return: Return;
}

export default class Foo extends Helper<FooSignature> {
export default class foo extends Helper<FooSignature> {
compute(positional: Positional, named: Named): Return {
return positional;
}
Expand Down
4 changes: 2 additions & 2 deletions test/__snapshots__/generate-modifier.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`generates a class-based \`.js\` modifier 1`] = `
"import Modifier from "ember-modifier";

export default class Foo extends Modifier {
export default class foo extends Modifier {
modify(element, positional, named) {}
}
"
Expand All @@ -24,7 +24,7 @@ export interface FooSignature {
Element: Element;
}

export default class Foo extends Modifier<FooSignature> {
export default class foo extends Modifier<FooSignature> {
modify(element: Element, positional: Positional, named: Named) {}
}
"
Expand Down
14 changes: 7 additions & 7 deletions test/__snapshots__/generate-service.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@
exports[`generates a \`.js\` service 1`] = `
"import Service from "@ember/service";

export default class Foo extends Service {}
export default class FooService extends Service {}
"
`;

exports[`generates a \`.js\` service at a custom path 1`] = `
"import Service from "@ember/service";

export default class Foo extends Service {}
export default class FooService extends Service {}
"
`;

exports[`generates a \`.ts\` service 1`] = `
"import Service from "@ember/service";

export default class Foo extends Service {}
export default class FooService extends Service {}

declare module "@ember/service" {
interface Registry {
"foo": Foo;
"foo": FooService;
}
}
"
Expand All @@ -30,11 +30,11 @@ declare module "@ember/service" {
exports[`generates a \`.ts\` service at a custom path 1`] = `
"import Service from "@ember/service";

export default class Foo extends Service {}
export default class FooService extends Service {}

declare module "@ember/service" {
interface Registry {
"foo": Foo;
"foo": FooService;
}
}
"
Expand All @@ -43,6 +43,6 @@ declare module "@ember/service" {
exports[`generates a nested \`.js\` service 1`] = `
"import Service from "@ember/service";

export default class FooBar extends Service {}
export default class FooBarService extends Service {}
"
`;