UPSTREAM: <carry>: Extend NodeLogQuery feature #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertinatto
force-pushed
the
rebase-1.27.0
branch
3 times, most recently
from
343df78 to
4457233
Compare
bertinatto
force-pushed
the
rebase-1.27.0
branch
2 times, most recently
from
99cea0c to
55ad533
Compare
bertinatto
force-pushed
the
rebase-1.27.0
branch
8 times, most recently
from
0157362 to
c7b3b08
Compare
bertinatto
force-pushed
the
rebase-1.27.0
branch
from
7b3214c to
68619bb
Compare
bertinatto
force-pushed
the
rebase-1.27.0
branch
2 times, most recently
from
6eb07bb to
f07de82
Compare
Extend the NodeLogQuery feature to support oc adm node-logs options: - Default NodeLogQuery feature gate to true - Add support for --since, --until, --case-sensitive, --output, options
bertinatto
force-pushed
the
rebase-1.27.0
branch
2 times, most recently
from
028c87f to
36386e3
Compare
bertinatto
force-pushed
the
rebase-1.27.0
branch
5 times, most recently
from
c5dc140 to
da711bf
Compare
bertinatto
pushed a commit
that referenced
this pull request
Sep 18, 2025
The code path for handling non-JSON output from etcd was broken:
- It did not skip over already parsed JSON output.
- It got stuck in the wrong for loop and repeatedly tried
parsing the same non-JSON output. This prevented test shutdown.
Not sure why yet, but in the branch with DRA v1 graduation the following error
started to show up for the first time (?!):
2025/07/18 19:24:48 WARNING: [core] [Server #3]grpc: Server.processUnaryRPC failed to write status: connection error: desc = "transport is closing"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the NodeLogQuery feature to support oc adm node-logs options: