Fix python version test with jinja2_native#204
Open
mytlogos wants to merge 2 commits intobertvv:masterfrom
Open
Fix python version test with jinja2_native#204mytlogos wants to merge 2 commits intobertvv:masterfrom
mytlogos wants to merge 2 commits intobertvv:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the ansible configuration setting "jinja2_native" is enabled, ansible (or jinja2?) tries to preserve the type of the variable, e.g. by casting a string like
'2'to a number2.This PR will a problem with this setting enabled with the variable
bind_packagesinvars/Debian.ymlandvars/RedHat.yml, where package name gets selected, depending on the configuredbind_python_versionvariable.If
jinja_native=truethe value ofbind_python_versionwould have been a number, selecting e.g. the non-existing python-netaddr package on some newer debian systems.Preventively casting the value to a string prevents this without breaking previous behaviour.