Skip to content

resolves #3 only use zoom for WebKit #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mojavelinux wants to merge 1 commit into
base: master
Choose a base branch
from
Open

resolves #3 only use zoom for WebKit #7

mojavelinux wants to merge 1 commit into from

Conversation

@mojavelinux
Copy link

@mojavelinux mojavelinux commented Sep 19, 2015

  • only use zoom strategy if browser can be identified as WebKit
  • fix tests (add classes so that styles take affect)

@mojavelinux
resolves bespokejs#3 only use zoom for WebKit
5b894c0 
- only use zoom strategy if browser can be identified as WebKit
- fix tests (add classes so that styles take affect)
@mojavelinux
Copy link
Author

mojavelinux commented Sep 19, 2015

There seems to be consensus that the webkitAppearance property is the best way to detect for WebKit. See http://stackoverflow.com/a/16459606/208063. It has proved effective for me thus far.

@mojavelinux mojavelinux mentioned this pull request Sep 19, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mojavelinux