Fixed ticker leak: DropdownMenuState was disposed with an active Ticker #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_fadeController is not dispose() at state's dispose() method, causing ticker leaking
This was referenced Aug 14, 2019
This fixes error like type '(XXX) => List<YYY>' is not a subtype of type '(dynamic) => List<dynamic>'
jweiw99
added a commit
to jweiw99/flutter_dropdown_menu
that referenced
this pull request
Feb 4, 2020
…to RandyWei-master Also migrate project to be Dart 3 compatible
This will fix "Cannot lerp between Rect.fromLTRB(0.0, -45.0, 0.0, 0.0) and Rect.fromLTRB(0.0, 0.0, 0.0, 0.0)" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_fadeController is not dispose() at state's dispose() method, causing ticker leaking.
This fixes #15