Add Save and Erase button for onboard logging

Author: haslinghuis

locales/en/messages.json

@@ -3558,6 +3558,10 @@
     "dataflashSaveFileDepreciationHint": {
         "message": "This method is slow and inherently prone to error / file corruption, because the MSP connection itself has intrinsic, fundamental limitations that make it unsuitable for file transfers. It may work for small log files only. Do not create support requests if file transfers fail when saved using this method. The recommended method is to use '<b>$t(onboardLoggingRebootMscText.message)</b>' (below) to activate the Mass Storage Mode, and access your flight controller as a storage device to download the log files."
     },
+    "dataflashButtonSaveAndErase": {
+        "message": "Save & Erase",
+        "description": "Button text to save blackbox logs to file and then erase the flash"
+    },
     "dataflashButtonErase": {
         "message": "Erase flash"
     },

src/js/tabs/onboard_logging.js

@@ -478,7 +478,19 @@ onboard_logging.initialize = function (callback) {
         });
     }
 
-    function flash_save_begin() {
+    function conditionallyEraseFlash(maxBytes, nextAddress) {
+        if (!isNaN(maxBytes) && nextAddress >= maxBytes) {
+            $(".dataflash-confirm-erase").addClass("erasing");
+            MSP.send_message(MSPCodes.MSP_DATAFLASH_ERASE, false, false, poll_for_erase_completion);
+        } else {
+            gui_log(
+                i18n.getMessage("dataflashSaveIncompleteWarning") ||
+                    "Downloaded size did not match expected size - not erasing flash.",
+            );
+        }
+    }
+
+    function flash_save_begin(alsoErase = false) {
         if (GUI.connected_to) {
             self.blockSize = self.BLOCK_SIZE;
 
@@ -515,6 +527,10 @@ onboard_logging.initialize = function (callback) {
                                             mark_saving_dialog_done(startTime, nextAddress, totalBytesCompressed);
                                         }
                                         FileSystem.closeFile(openedFile);
+                                        // Optionally erase after successful full download
+                                        if (!saveCancelled && alsoErase) {
+                                            conditionallyEraseFlash(maxBytes, nextAddress);
+                                        }
                                     } else {
                                         if (!self.writeError) {
                                             mspHelper.dataflashRead(nextAddress, self.blockSize, onChunkRead);
@@ -528,6 +544,9 @@ onboard_logging.initialize = function (callback) {
                                 // A zero-byte block indicates end-of-file, so we're done
                                 mark_saving_dialog_done(startTime, nextAddress, totalBytesCompressed);
                                 FileSystem.closeFile(openedFile);
+                                if (alsoErase) {
+                                    conditionallyEraseFlash(maxBytes, nextAddress);
+                                }
                             }
                         } else {
                             // There was an error with the received block (address didn't match the one we asked for), retry

src/tabs/onboard_logging.html

@@ -110,7 +110,9 @@ <h3 i18n="dataflashSavingTitle"></h3>
 
                             <div class="dataflash-buttons">
                                 <a class="regular-button erase-flash" href="#" i18n="dataflashButtonErase"></a>
+                                <a class="regular-button require-msc-not-supported save-flash-erase" href="#" i18n="dataflashButtonSaveAndErase"></a>
                                 <a class="regular-button require-msc-not-supported save-flash" href="#" i18n="dataflashButtonSaveFile"></a>
+                                <a class="regular-button require-msc-supported save-flash-erase" href="#" i18n="dataflashButtonSaveAndErase"></a>
                                 <a class="regular-button require-msc-supported save-flash" href="#"><span i18n="dataflashButtonSaveFileDeprecated"></span><span class="helpicon cf_tip" i18n_title="dataflashSaveFileDepreciationHint"></span></a>
                                 <p i18n="dataflashSavetoFileNote"></p>
                             </div>