Added Spektrum SRXL2 to serialRXtypes #1559
Conversation
src/js/tabs/configuration.js
Outdated
|
|
||
|
|
||
| if (semver.gte(CONFIG.apiVersion, "1.42.0")) { | ||
| serialRXtypes.push('SPEKTRUM SRXL2'); |
There was a problem hiding this comment.
Since DJI_HDL_7MS and SPEKTRUM SRXL2 are both added in the same version you should add your push to that block, right after the DJI one.
There was a problem hiding this comment.
Ah right. Did a force push with the change amended to last commit with the correction
There was a problem hiding this comment.
Take a look to the spi push elemnts a little later in the code. We use only one call to the push method passing all the elements needed. For coherence is better to maintain only one push and not one for element.
There was a problem hiding this comment.
Take a look to the spi push elemnts a little later in the code. We use only one call to the push method passing all the elements needed. For coherence is better to maintain only one push and not one for element.
I've addressed the issue in the last commit. :)
src/js/tabs/configuration.js
Outdated
|
|
||
|
|
||
| if (semver.gte(CONFIG.apiVersion, "1.42.0")) { | ||
| serialRXtypes.push('SPEKTRUM SRXL2'); |
There was a problem hiding this comment.
Take a look to the spi push elemnts a little later in the code. We use only one call to the push method passing all the elements needed. For coherence is better to maintain only one push and not one for element.
5 participants
Related to betaflight pull request
betaflight/betaflight#8606
New serial protocol option for Spektrum receivers