Make the 'Update Firmware' buttom more consistent #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before: click 'Update Firmware' and tabs would disappear At the time of implementation the Update Firmware button was hiding all the tabs. Then click again to show the Landing and Help tab. Now: |
Member
|
Noice! |
McGiverGim
approved these changes
Aug 10, 2019
Member
McGiverGim
left a comment
McGiverGim
left a comment
There was a problem hiding this comment.
Thanks for that! At least, now this button is less crazy 🤪
Contributor
Author
|
We could always add:
|
Member
Do you have any suggestion on how to do this, and not force users back into the 'disconnect at the top right, then select firmware flasher at the bottom left' UX nightmare of a way to get into the firmware flasher? |
Contributor
Author
|
Hi, I was sarcastically suggesting this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figure the 'Update Firmware' button should be red any time we're looking at the Firmware Flashing tab