Skip to content

fix unknown msp code 33 & 225 detected #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

fix unknown msp code 33 & 225 detected #2280

merged 1 commit into from
Nov 19, 2020

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 18, 2020 •
edited
Loading

Save and reboot in failsafe.js results in an unknown code detected: 225.
Added MSP_SET_GPS_RESCUE case to MSPHelper.prototype.process_data to resolve.

Using save on Power & Battery Tab in power.js results in unknown code detected: 33.
Added MSP_SET_BATTERY_CONFIG case to same function.

McGiverGim
McGiverGim previously approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

mikeller
mikeller previously approved these changes Nov 18, 2020
View reviewed changes
@mikeller mikeller added this to the 10.8.0 milestone Nov 18, 2020
@haslinghuis haslinghuis dismissed stale reviews from mikeller and McGiverGim via 8c8ef16 November 18, 2020 20:25
@haslinghuis haslinghuis force-pushed the fix_unknown_code_detected branch from 8faed33 to 8c8ef16 Compare November 18, 2020 20:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis
Copy link
Member Author

haslinghuis commented Nov 18, 2020 •
edited
Loading

Checked all save (and reboot) buttons 😄

@haslinghuis haslinghuis changed the title fix unknown msp code 225 detected fix unknown msp code 33 & 225 detected Nov 18, 2020
@mikeller mikeller merged commit 56e5299 into betaflight:master Nov 19, 2020
@haslinghuis haslinghuis deleted the fix_unknown_code_detected branch November 19, 2020 16:25
@mikeller mikeller modified the milestones: 10.8.0, 10.7.1 Oct 10, 2021
mikeller added a commit that referenced this pull request Oct 10, 2021
@mikeller
Merge pull request #2280 from haslinghuis/fix_unknown_code_detected
6e58ae3 
fix unknown msp code 33 & 225 detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@mikeller mikeller mikeller approved these changes

Assignees

No one assigned

Labels

RN: BUGFIX

Projects

None yet

Milestone

10.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@haslinghuis @McGiverGim @mikeller