cordova_serial.requestPermission() driver fix #2441
Conversation
haslinghuis
left a comment
haslinghuis
left a comment
There was a problem hiding this comment.
Should also add the device to ./cordova/usb_device_filter.xml:
<usb-device vendor-id="4292" product-id="60000" /> <!-- 0xea60: CP2102 and other CP210x single port devices -->
|
Kudos, SonarCloud Quality Gate passed!
|
done |
McGiverGim
left a comment
McGiverGim
left a comment
There was a problem hiding this comment.
Not tested, but it seems ok to me.
|
@danybd can you please Squash your commits into only one? |
Fight controller based on silabs CP2104 was not working as function call cordova_serial.requestPermission() without specify the driver parameter uses the default driver "CdcAcmSerialDriver" which is the wrong when usb-uart chip is a CP2104. This chip requires the driver "Cp21xxSerialDriver" fix code smells fix the automatically reported code smells 'CdcAcmSerialDriver' as default driver In order to not rely on the fallback driver in the driver library define 'CdcAcmSerialDriver' explicit locally Co-authored-by: haslinghuis <[email protected]> add CP2102 and other CP210x single port devices into usb device filter
mikeller
dismissed stale reviews from McGiverGim, haslinghuis, and themself
via
f4abe55
|
Kudos, SonarCloud Quality Gate passed!
|
|
AUTOMERGE: (PASS)
|
|
@danybd Thanks for your contribution. Sorry it took so long but we are in a process to automate some processes. Here is the release: https://github.com/betaflight/betaflight-configurator-nightlies/releases/tag/v20210616.3059 |
|
@haslinghuis happy to make betaflight a little bit better :) Do you know guys when is the release 10.8.0 planned (if 10.8.0 is actually the next version)? |
6 participants
Fight controller based on silabs CP2104 was not working as function call cordova_serial.requestPermission() without specify the driver parameter uses the default driver "CdcAcmSerialDriver" which is the wrong when usb-uart chip is a CP2104. This chip requires the driver "Cp21xxSerialDriver". It fixes #2437